fix: Fixes labels and annotations#441
fix: Fixes labels and annotations#441jared-schmidt-niceincontact wants to merge 1 commit intokedacore:mainfrom
Conversation
Signed-off-by: Jared Schmidt <jared.schmidt@nice.com>
jared-schmidt-niceincontact
changed the title
mkilchhofer
left a comment
mkilchhofer
left a comment
There was a problem hiding this comment.
Additional if you change keys inside values.yaml you need to also adapt the README.md
| # annotations: | ||
| # foo: bar |
There was a problem hiding this comment.
Don't comment-out the key.
| # annotations: | ||
| # foo: bar |
There was a problem hiding this comment.
Don't comment-out the key.
| # additionalAnnotations: | ||
| # foo: bar |
There was a problem hiding this comment.
Don't comment-out the key.
| # additionalLabels: | ||
| # foo: bar |
There was a problem hiding this comment.
Don't comment-out the key.
| relabellings: [] | ||
| relabelings: [] |
There was a problem hiding this comment.
This is kinda breaking. But if we accept this, this change needs to be reflected into the 3 servicemonitor.yaml files:
- templates/manager/servicemonitor.yaml
- templates/webhooks/servicemonitor.yaml
- templates/metrics-server/servicemonitor.yaml
There was a problem hiding this comment.
Agreed, we should not break this
| relabellings: [] | ||
| relabelings: [] |
There was a problem hiding this comment.
This is kinda breaking. But if we accept this, this change needs to be reflected into the 3 servicemonitor.yaml files:
- templates/manager/servicemonitor.yaml
- templates/webhooks/servicemonitor.yaml
- templates/metrics-server/servicemonitor.yaml
There was a problem hiding this comment.
Agreed, we should not break this
tomkerkhove
left a comment
tomkerkhove
left a comment
There was a problem hiding this comment.
LGTM, but I have the same comments such as @mkilchhofer. Please process them and also undo all changes in the values file wrt commenting things
3 participants
Provide a description of what has been changed
Labels and annotations have been fixed throughout the templates so that they actually work. The "annotation" key in the metadata is included or excluded depending on if it has content. The "{}" in several of the annotation overrides in the values.yaml file was causing the "helm template" command to break when a value was defined in an external values.yaml file. This bug has also been fixed. Several whitespace gobbling issues have been fixed where labels and annotations were being appended to the previous line.
Checklist
Fixes #
#437